Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a GitHub Action to update the Docker Hub description #213

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request updates the build workflow to use the peter-evans/dockerhub-description Action to update the image description on Docker Hub and to only do so on a push event to the develop branch.

💭 Motivation and context

It makes sense to leverage an Action for work being done in GitHub Actions when possible. It also makes sense to limit updates to the Docker Hub description to changes that have moved through the approval process.

🧪 Testing

Automated tests pass. I also verified that the Update the Docker Hub description step did not run.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

Use the peter-evans/dockerhub-description Action to update the Docker
Hub description instead of a bash script.
Instead of updating the description whenever the `build` workflow is
run we will only update the description on `push` events to the
`develop` branch. This will ensure that only approved edits are pushed
to Docker Hub.
@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use github-actions Pull requests that update GitHub Actions code security This issue or pull request addresses a security issue labels Feb 10, 2025
@mcdonnnj mcdonnnj requested a review from a team February 10, 2025 21:49
@mcdonnnj mcdonnnj self-assigned this Feb 10, 2025
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mahvelous! 👍

@mcdonnnj mcdonnnj added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label Feb 11, 2025
@mcdonnnj mcdonnnj added this pull request to the merge queue Feb 11, 2025
Merged via the queue into develop with commit 797859d Feb 11, 2025
17 checks passed
@mcdonnnj mcdonnnj deleted the improvement/use_action_for_docker_hub_update branch February 11, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release security This issue or pull request addresses a security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants