Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct input to the peter-evans/dockerhub-description Action #214

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Feb 11, 2025

🗣 Description

This pull request fixes an input to the peter-evans/dockerhub-description Action to be one that actually exists.

💭 Motivation and context

I'm not sure what I was doing in #213 but I used an input that doesn't exist for the Action. When that PR was merged I checked to verify the the step using this Action was run and saw the ominous Warning: Unexpected input(s) 'description', valid inputs are ['username', 'password', 'repository', 'short-description', 'readme-filepath', 'enable-url-completion', 'image-extensions'].

🧪 Testing

Automated tests pass. I verified that all inputs actually exist for the Action in question.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

This replaces a nonexistent input name with the valid one.
@mcdonnnj mcdonnnj added bug This issue or pull request addresses broken functionality github-actions Pull requests that update GitHub Actions code labels Feb 11, 2025
@mcdonnnj mcdonnnj requested a review from a team February 11, 2025 17:01
@mcdonnnj mcdonnnj self-assigned this Feb 11, 2025
@mcdonnnj mcdonnnj added this pull request to the merge queue Feb 11, 2025
Merged via the queue into develop with commit 9ad5df4 Feb 11, 2025
17 checks passed
@mcdonnnj mcdonnnj deleted the bug/fix_action_input branch February 11, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality github-actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants