Remove functionality to create special buildx Dockerfile #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to go through this step as the Dockerfile that is generated simply implements default behavior. This can be seen in the annotations our GitHub Actions runs show: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior: Dockerfile-x#L9 RedundantTargetPlatform: Setting platform to predefined $TARGETPLATFORM in FROM is redundant as this is the default behavior More info: https://docs.docker.com/go/dockerfile/rule/redundant-target-platform/
mcdonnnj
added
improvement
jsf9k
approved these changes
Feb 3, 2025
dav3r
approved these changes
Feb 5, 2025
mcdonnnj
added
the
kraken 🐙
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request removes the
buildx-dockerfile.shscript and related use in our GitHub Actions configuration.💭 Motivation and context
There is no need to generate a Dockerfile that simply implements the default behavior. We can see the following annotation in GitHub Actions runs that confirms this behavior:
🧪 Testing
Automated tests pass. I also confirmed that we are still seeing the expected platform support on Docker Hub for images created with this branch as can be seen here.
✅ Pre-approval checklist