Use docker/build-push-action default behavior
#217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of overriding the context and file we can allow the Action to fall back on its default behaviour of using the `git` context to pull the source needed to build the image. This also allows us to remove the actions/checkout Action from the `build` and `build-push-all` jobs.
mcdonnnj
added
improvement
jsf9k
approved these changes
Feb 20, 2025
dv4harr10
approved these changes
Feb 20, 2025
mcdonnnj
added
the
kraken 🐙
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request removes using the actions/checkout Action from the
buildandbuild-push-allsteps as well as removing thecontextandfilearguments to the docker/build-push-action Action.💭 Motivation and context
I was doing some research on Docker Bake and ran into a comment in the docker/bake-action documentation that mentioned using the
gitcontext to pull data just like the docker/build-push-action Action and confirmed that from the README. Since we removed the adjusted Dockerfile-fu in #211 it makes sense to further simplify these jobs.🧪 Testing
Automated tests pass.
✅ Pre-approval checklist