Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define ANSIBLE_ROLES_PATH for the ansible provisioner #221

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jan 30, 2025

🗣 Description

This pull request modifies the molecule.yml file to define the ANSIBLE_ROLES_PATH environment variable, inserting the path to the repository checkout directory.

💭 Motivation and context

molecule used to modify the roles path for us, but as of v25.2.0 no longer does. (See ansible/molecule#4380 for details.) As a result we must now modify it ourselves.

Without this change molecule can no longer find the skeleton-ansible-role Ansible role.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

Molecule used to modify the roles path for us, but as of v25.2.0 no
longer does.  (See ansible/molecule#4380 for details.)  As a result we
must now modify it ourselves.
@jsf9k jsf9k added the bug This issue or pull request addresses broken functionality label Jan 30, 2025
@jsf9k jsf9k self-assigned this Jan 30, 2025
@jsf9k jsf9k marked this pull request as ready for review January 30, 2025 15:47
@jsf9k jsf9k requested a review from a team January 30, 2025 15:47
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works for you, then it works for me. 👍

Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable enough solution to this problem. I have one question for your consideration.

molecule/default/molecule.yml Show resolved Hide resolved
@jsf9k jsf9k added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@jsf9k jsf9k added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@jsf9k jsf9k merged commit 37a097e into develop Jan 31, 2025
57 checks passed
@jsf9k jsf9k deleted the bugfix/handle-molecule-breaking-change branch January 31, 2025 18:10
jsf9k added a commit to cisagov/ansible-role-assessment-tool that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
Development

Successfully merging this pull request may close these issues.

4 participants