-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define ANSIBLE_ROLES_PATH
for the ansible
provisioner
#221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Molecule used to modify the roles path for us, but as of v25.2.0 no longer does. (See ansible/molecule#4380 for details.) As a result we must now modify it ourselves.
This was referenced Jan 30, 2025
Closed
dv4harr10
approved these changes
Jan 30, 2025
dav3r
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it works for you, then it works for me. 👍
mcdonnnj
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a reasonable enough solution to this problem. I have one question for your consideration.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 31, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 31, 2025
jsf9k
added a commit
to cisagov/ansible-role-assessment-tool
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request modifies the
molecule.yml
file to define theANSIBLE_ROLES_PATH
environment variable, inserting the path to the repository checkout directory.💭 Motivation and context
molecule
used to modify the roles path for us, but as of v25.2.0 no longer does. (See ansible/molecule#4380 for details.) As a result we must now modify it ourselves.Without this change
molecule
can no longer find theskeleton-ansible-role
Ansible role.🧪 Testing
All automated tests pass.
✅ Pre-approval checklist