Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin Molecule to <25.2.0 #220

Closed
wants to merge 1 commit into from
Closed

Pin Molecule to <25.2.0 #220

wants to merge 1 commit into from
+9 −1

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jan 28, 2025 •
edited
Loading

🗣 Description

This pull request adds a pin to restrict molecule to <25.2.0.

This upper-bound pin should be removed when possible. See #219 for more details.

💭 Motivation and context

As of molecule v25.2.0, Molecule no longer adds the current project directory to the search path for Ansible roles. This breaks our current Molecule testing, since Ansible does not find the local copy of the role being tested. For now, it makes sense to pin molecule to <25.2.0 until we figure out how to deal with this change.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k
Pin Molecule to <25.2.0
7cc87d2 
As of Molecule v25.2.0, Molecule no longer adds the current project
directory to the search path for Ansible roles.  This breaks our
current Molecule testing, since Ansible does not find the local copy
of the role being tested.  For now, it makes sense to pin to <25.2.0
until we figure out how to deal with this change.
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality dependencies Pull requests that update a dependency file labels Jan 28, 2025
@jsf9k jsf9k self-assigned this Jan 28, 2025
@jsf9k jsf9k marked this pull request as ready for review January 28, 2025 19:43
@jsf9k jsf9k requested a review from a team January 28, 2025 19:44
@jsf9k jsf9k mentioned this pull request Jan 28, 2025
Closed
6 tasks
dav3r
dav3r approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📌

mcdonnnj
mcdonnnj approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📌

@jsf9k
Copy link
Member Author

jsf9k commented Jan 30, 2025

Closed in favor of #221.

@jsf9k jsf9k closed this Jan 30, 2025
@jsf9k jsf9k mentioned this pull request Jan 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

Labels
bug This issue or pull request addresses broken functionality dependencies Pull requests that update a dependency file
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @dav3r @mcdonnnj @dv4harr10