Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement functional testing #9

Open
mcdonnnj opened this issue May 6, 2022 · 1 comment
Open

Implement functional testing #9

mcdonnnj opened this issue May 6, 2022 · 1 comment
Assignees
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@mcdonnnj
Copy link
Member

mcdonnnj commented May 6, 2022

🐛 Summary

Once #8 is merged a large number of the tests defined in this repository will be disabled. This is due to the fact that they were written based on working out of a running Docker orchestration and not stand-alone package testing. Given how our GitHub Actions testing is written this is not readily implementable for this project. It is also desirable to have stand-alone testing for the Python package if at possible.

Expected behavior

Using our GitHub Actions workflow or running pytest locally results in all tests that are defined passing.

implementation notes

When testing trying to get them running as-is I first added pyfakefs to insert an appropriate configuration file at the default location (/run/secrets/admiral.yml). Once I was able to do that I then ran into the problem that it needs a running redis server.

@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label May 6, 2022
This was referenced Mar 16, 2023
@king-alexander king-alexander self-assigned this Apr 19, 2023
@king-alexander king-alexander moved this from READY to WIP in 👨‍✈️ Admiral Jun 23, 2023
@king-alexander king-alexander moved this from WIP to READY in 👨‍✈️ Admiral Jun 27, 2023
@king-alexander king-alexander moved this from READY to WIP in 👨‍✈️ Admiral Jul 10, 2023
@king-alexander king-alexander moved this from WIP to READY in 👨‍✈️ Admiral Jul 17, 2023
@king-alexander king-alexander moved this from READY to BACKLOG in 👨‍✈️ Admiral Jul 28, 2023
@king-alexander
Copy link
Collaborator

This will be easier to tackle once all the various components are split up into their respective repositories. See cisagov/admiral-docker#5 and cisagov/ansible-role-admiral#3.

@king-alexander king-alexander moved this from BACKLOG to READY in 👨‍✈️ Admiral Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

No branches or pull requests

2 participants