Update mongo tests #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
king-alexander
added
breaking change
king-alexander
force-pushed
the
improvement/update-mongo-tests
branch
from
3321f90
to
a3a4956
Compare
king-alexander
added
test
king-alexander
force-pushed
the
improvement/update-mongo-tests
branch
from
a3a4956
to
7ac7740
Compare
king-alexander
removed
the
question
king-alexander
requested review from
dav3r,
felddy,
jasonodoom,
jsf9k and
mcdonnnj
as code owners
jsf9k
reviewed
Jun 28, 2023
king-alexander
force-pushed
the
improvement/update-mongo-tests
branch
from
193ac57
to
7197959
Compare
jsf9k
reviewed
Jul 6, 2023
Yes, please let us know when the GH Actions all pass and then we will finalize our reviews. |
king-alexander
force-pushed
the
improvement/update-mongo-tests
branch
from
7197959
to
ea7b9fc
Compare
|
I will add a test to boost coverage and make the Coveralls check happy. |
The 'mongomock://' URI is deprecated, so the connection URIs now start with 'mongodb://'.
This test broke once the 'mongomock://' URI was no longer supported. I had to rewrite the test to use the new connection method.
The mongomock connection method introduced in MongoEngine 0.27.0 is not recognized in Python 3.6.
This commit augments `connect_from_config()` with a `client` argument to determine which client class to use when called. The default client class for MongoEngine (`pymongo.MongoClient`) is explicitly made the default value so alternative client classes can be specified where necessary.
Connect MongoEngine with mongomock to test connections from a configuration.
king-alexander
force-pushed
the
improvement/update-mongo-tests
branch
from
ea7b9fc
to
13e08b6
Compare
The 6.0 release contains a temporary workaround to a regression in Cython 3.10.0a10 that throws an attribute error. See more details upstream at yaml/pyyaml#601 and yaml/pyyaml#702.
This fabricated subject covers domains that end in "fed.us" to boost test coverage.
The Docker Compose package is causing a dependency conflict. And with respect to #40, the package no longer belongs in this project.
king-alexander
force-pushed
the
improvement/update-mongo-tests
branch
from
1ec6a6a
to
a24c345
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
These changes update tests that connect to a mock Mongo database.
💭 Motivation and context
🧪 Testing
I modified the tests that connect to a mock Mongo database to use the new connection method. After my changes, all tests passed locally.
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist