Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin MongoEngine #49

Merged
merged 3 commits into from
Mar 22, 2023
Merged

Pin MongoEngine #49

merged 3 commits into from
Mar 22, 2023

Conversation

king-alexander
Copy link
Collaborator

@king-alexander king-alexander commented Mar 16, 2023

🗣 Description

I pinned MongoEngine to a version between 0.16.3 and 0.27.0.

💭 Motivation and context

MongoEngine 0.27.0 introduces a breaking change to the Mongomock connection method. This breaks our tests that connect to a mock database.

🧪 Testing

I rebuilt the admiral image with the new MongoEngine requirements. All tests passed locally.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@king-alexander king-alexander added the dependencies Pull requests that update a dependency file label Mar 16, 2023
@king-alexander king-alexander marked this pull request as ready for review March 16, 2023 16:15
setup.py Show resolved Hide resolved
@king-alexander king-alexander force-pushed the bugfix/pin-mongoengine branch from b2780a7 to 76fd2a6 Compare March 20, 2023 17:12
@king-alexander king-alexander mentioned this pull request Mar 21, 2023
2 tasks
MongoEngine 0.27.0 introduces a breaking change to the mongomock
connection method.
@king-alexander king-alexander force-pushed the bugfix/pin-mongoengine branch from 76fd2a6 to 5f2bb25 Compare March 21, 2023 16:22
@king-alexander king-alexander requested a review from dav3r March 21, 2023 17:25
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@king-alexander king-alexander merged commit 6953121 into develop Mar 22, 2023
@king-alexander king-alexander deleted the bugfix/pin-mongoengine branch March 22, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants