Skip to content

tetragon: assorted fixes #4131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2025
Merged

tetragon: assorted fixes #4131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17f081d
tetragon: Remove confapi package with TetragonConf object
olsajiri Oct 14, 2025
1d59009
tetragon: Use t.Run function to TestExecParse
olsajiri Sep 26, 2025
c0afd7e
tetragon: Set correct size in execParse error path
olsajiri Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions pkg/api/confapi/confapi.go
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion pkg/sensors/exec/exec_linux.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ func execParse(reader *bytes.Reader) (processapi.MsgProcess, bool, error) {
size := exec.Size - processapi.MSG_SIZEOF_EXECVE
if size > processapi.MSG_SIZEOF_BUFFER-processapi.MSG_SIZEOF_EXECVE {
err := errors.New("msg exec size larger than argsbuffer")
exec.Size = processapi.MSG_SIZEOF_EXECVE
proc.Size = processapi.MSG_SIZEOF_EXECVE
proc.Args = "enomem enomem"
proc.Filename = "enomem"
return proc, false, err
Expand Down
36 changes: 19 additions & 17 deletions pkg/sensors/exec/exec_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,10 +788,7 @@ func TestExecParse(t *testing.T) {
t.Fatalf("observer.InitDataCache: %s", err)
}

exec := processapi.MsgExec{
Size: processapi.MSG_SIZEOF_EXECVE,
}

exec := processapi.MsgExec{}
filename := []byte("/bin/krava")
cwd := []byte("/home/krava")

Expand All @@ -808,7 +805,9 @@ func TestExecParse(t *testing.T) {

var err error

{
t.Run("Empty args", func(t *testing.T) {
observer.DataPurge()

// - filename (string)
// - no args
// - cwd (string)
Expand All @@ -834,11 +833,11 @@ func TestExecParse(t *testing.T) {
decArgs, decCwd := proc.ArgsDecoder(process.Args, process.Flags)
assert.Empty(t, decArgs)
assert.Equal(t, string(cwd), decCwd)
}
})

observer.DataPurge()
t.Run("Filename as data event", func(t *testing.T) {
observer.DataPurge()

{
// - filename (data event)
// - no args
// - cwd (string)
Expand Down Expand Up @@ -870,11 +869,11 @@ func TestExecParse(t *testing.T) {
decArgs, decCwd := proc.ArgsDecoder(process.Args, process.Flags)
assert.Empty(t, decArgs)
assert.Equal(t, string(cwd), decCwd)
}
})

observer.DataPurge()
t.Run("Args as data event", func(t *testing.T) {
observer.DataPurge()

{
// - filename (string)
// - args (data event)
// - cwd (string)
Expand Down Expand Up @@ -911,11 +910,11 @@ func TestExecParse(t *testing.T) {
decArgs, decCwd := proc.ArgsDecoder(process.Args, process.Flags)
assert.Equal(t, "arg1 arg2", decArgs)
assert.Equal(t, string(cwd), decCwd)
}
})

observer.DataPurge()
t.Run("Filename and args as data event", func(t *testing.T) {
observer.DataPurge()

{
// - filename (data event)
// - args (data event)
// - cwd (string)
Expand Down Expand Up @@ -956,9 +955,11 @@ func TestExecParse(t *testing.T) {
decArgs, decCwd := proc.ArgsDecoder(process.Args, process.Flags)
assert.Equal(t, "arg1 arg2", decArgs)
assert.Equal(t, string(cwd), decCwd)
}
})

t.Run("Filename and args as non-utf8", func(t *testing.T) {
observer.DataPurge()

{
// - filename (non-utf8)
// - args (data event, non-utf8)
// - cwd (string)
Expand Down Expand Up @@ -997,7 +998,8 @@ func TestExecParse(t *testing.T) {
decArgs, decCwd := proc.ArgsDecoder(process.Args, process.Flags)
assert.Equal(t, "�( arg2", decArgs)
assert.Equal(t, strutils.UTF8FromBPFBytes(cwd), decCwd)
}
})

observer.DataPurge()
}

Expand Down
Loading