tetragon: assorted fixes #4131
Merged
tetragon: assorted fixes #4131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsajiri
added
the
release-note/minor
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
from
9c785b9 to
07dd27a
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
from
07dd27a to
8d09c3c
Compare
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
from
8d09c3c to
b4a1ba3
Compare
olsajiri
changed the title
Contributor
Author
|
fyi moved ongoing exec changes in here #4184 |
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
from
b4a1ba3 to
19685fc
Compare
tpapagian
approved these changes
Oct 15, 2025
kkourt
approved these changes
Oct 16, 2025
mtardy
approved these changes
Oct 16, 2025
bpf/process/bpf_execve_event.c
Outdated
Comment on lines
362
to
364
| // reuse p->args first string that contains the filename, this can't be | ||
| // above 256 in size (otherwise the complete will be send via data msg) | ||
| // which is okay because we need the 256 first bytes. | ||
| curr->bin.path_length = probe_read_str(curr->bin.path, BINARY_PATH_MAX_LEN, &p->args); | ||
| char *filename = (char *)ctx + (_(ctx->__data_loc_filename) & 0xFFFF); | ||
|
|
||
| curr->bin.path_length = probe_read_str(curr->bin.path, BINARY_PATH_MAX_LEN, (void *)filename); |
Member
There was a problem hiding this comment.
what's the change from reading from the tracing points args?
Contributor
Author
There was a problem hiding this comment.
I'm changing the data layout a bit in another PR and thought this might go independently, but it's not apparent without the rest of the changes, so I'll skip it for now
It's not used, we use TetragonConfValue instead. Signed-off-by: Jiri Olsa <[email protected]>
Add some structure to the execParse tests. Signed-off-by: Jiri Olsa <[email protected]>
We need to set process size, not exec object. Signed-off-by: Jiri Olsa <[email protected]>
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
from
19685fc to
c0afd7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assorted fixes