-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[ENH] Support using schema embedding function for dense vectors, allow document source key for sparse #5617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Enhance Schema Embedding Logic and Sparse Embedding Function Registration This pull request introduces support for leveraging the embedding function defined in the schema on a collection during the Key Changes• Added support in Affected Areas• This summary was automatically generated by @propel-code-bot |
357259b
to
e2d52d1
Compare
e2d52d1
to
bd0e70d
Compare
4212a46
to
20bcadf
Compare
bd0e70d
to
7697fa1
Compare
20bcadf
to
6515339
Compare
7697fa1
to
c92cdf5
Compare
6515339
to
170673c
Compare
c92cdf5
to
a02dcea
Compare
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
added tests in stacked pr for e2e schema tests
pytest
for python,yarn test
for js,cargo test
for rustMigration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?