-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[TST] Add schema e2e tests #5616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
bbfbed8
to
5c434c5
Compare
bd4398d
to
357259b
Compare
bc6c705
to
93a1561
Compare
357259b
to
e2d52d1
Compare
Add Comprehensive End-to-End Schema Tests This PR introduces a suite of end-to-end ( Key Changes• Introduced extensive e2e tests validating schema persistence, index configuration, and lifecycle for collections in Affected Areas• This summary was automatically generated by @propel-code-bot |
93a1561
to
cc00309
Compare
e2d52d1
to
bd0e70d
Compare
cc00309
to
f40f1ea
Compare
f40f1ea
to
e3a6cb8
Compare
bd0e70d
to
7697fa1
Compare
e3a6cb8
to
5439079
Compare
7697fa1
to
c92cdf5
Compare
5439079
to
8bd6af6
Compare
8bd6af6
to
be61947
Compare
c92cdf5
to
a02dcea
Compare
persisted_schema = collection.schema | ||
assert persisted_schema is not None | ||
|
||
vector_index = persisted_schema.keys["#embedding"].float_list.vector_index | ||
print(persisted_schema.serialize_to_json()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[BestPractice]
Debug print statement should be removed before merging. This print(persisted_schema.serialize_to_json())
statement appears to be leftover debugging code that will clutter test output in production.
persisted_schema = collection.schema | |
assert persisted_schema is not None | |
vector_index = persisted_schema.keys["#embedding"].float_list.vector_index | |
print(persisted_schema.serialize_to_json()) | |
persisted_schema = collection.schema | |
assert persisted_schema is not None | |
embedding_override = persisted_schema.keys["#embedding"].float_list |
⚡ Committable suggestion
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Context for Agents
[**BestPractice**]
Debug print statement should be removed before merging. This `print(persisted_schema.serialize_to_json())` statement appears to be leftover debugging code that will clutter test output in production.
```suggestion
persisted_schema = collection.schema
assert persisted_schema is not None
embedding_override = persisted_schema.keys["#embedding"].float_list
```
⚡ **Committable suggestion**
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
File: chromadb/test/api/test_schema_e2e.py
Line: 99
be61947
to
9322a2c
Compare
a02dcea
to
37d20ea
Compare
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustMigration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?