Skip to content

Conversation

jackkoenig
Copy link
Contributor

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Backend code generation

Desired Merge Strategy

  • Squash

Release Notes

Previously they would result in an extra '_' in the same of the signal.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

Previously they would result in an extra '_' in the same of the signal.
Also delete duplicate implementation of prefix.
@jackkoenig jackkoenig added the Backend Code Generation Affects backend code generation, will be included in release notes label Oct 17, 2025
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. The new behavior makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend Code Generation Affects backend code generation, will be included in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants