Fail boring into module with endIOCreation set#4925
Merged
Conversation
mwachs5
reviewed
May 13, 2025
mwachs5
reviewed
May 13, 2025
mwachs5
approved these changes
Jul 1, 2025
Contributor
mwachs5
left a comment
There was a problem hiding this comment.
looks good. the only minor improvement i might add would be a source locator for where endIOCreation was called so you could put it in the error message.
3352832 to
a775276
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor Checklist
docs/src?Type of Improvement
Release Notes
Setting
endIOCreationnow also errors if any IOs are created usingBoringUtils.Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.