Skip to content

inlinetest: Remove type parameter R from test body, testharness, etc.#4890

Closed
tmckay-sifive wants to merge 1 commit intochipsalliance:mainfrom
tmckay-sifive:tmckay/inlinetest-result
Closed

inlinetest: Remove type parameter R from test body, testharness, etc.#4890
tmckay-sifive wants to merge 1 commit intochipsalliance:mainfrom
tmckay-sifive:tmckay/inlinetest-result

Conversation

@tmckay-sifive
Copy link
Contributor

@tmckay-sifive tmckay-sifive commented Apr 15, 2025

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API modification

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

  • Remove the type parameter R throughout chisel3.experimental.inlinetest
  • Introduce TestBehavior, which specifies some details about how a test should finish.

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@tmckay-sifive
Copy link
Contributor Author

Superseded by #4946.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants