Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank variation returned for minimum index #42

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

pdil
Copy link
Member

@pdil pdil commented Sep 11, 2024

  • Passing in .minimum to MoveTree.fullVariation(for:) returned an empty array even if there were valid moves in the move tree.
  • If this value is passed, it will use the first valid index (.minimum.next) to calculate the moves contained in the variation.

@pdil pdil added the bug A bug or issue that should be resolved label Sep 11, 2024
@pdil pdil self-assigned this Sep 11, 2024
@pdil pdil force-pushed the bugfix/full-variation-for-min-index branch from 1a69511 to fec61ec Compare September 11, 2024 19:58
@pdil pdil marked this pull request as ready for review September 11, 2024 20:00
@pdil pdil merged commit e420a47 into master Sep 11, 2024
5 checks passed
@pdil pdil deleted the bugfix/full-variation-for-min-index branch September 11, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug or issue that should be resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant