Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator outputs misleading errors when NaN values are in required Visium .obs columns #1196

Open
Jchaffer787 opened this issue Jan 23, 2025 · 1 comment
Assignees
Labels
5.3 Next minor CELLxGENE schema version after 5.2 curation software

Comments

@Jchaffer787
Copy link
Collaborator

If a NaN value is present in adata.obs['array_col'], ['array_row'], and/or ['in_tissue'], validator error output:

ERROR: obs['array_col'] is required for obs['assay_ontology_term_id'] 'EFO:0010961' (Visium Spatial Gene Expression) and uns['spatial']['is_single'] is True.

ERROR: obs['array_row'] is required for obs['assay_ontology_term_id'] 'EFO:0010961' (Visium Spatial Gene Expression) and uns['spatial']['is_single'] is True.

ERROR: obs['in_tissue'] is required for obs['assay_ontology_term_id'] 'EFO:0010961' (Visium Spatial Gene Expression) and uns['spatial']['is_single'] is True.

Implies fields are absent, instead of pointing towards the value issue.

@brianraymor brianraymor added the 5.3 Next minor CELLxGENE schema version after 5.2 label Jan 29, 2025
@ejmolinelli ejmolinelli self-assigned this Jan 29, 2025
@ejmolinelli
Copy link
Contributor

We are now differentiating between TISSUE_POSITION_COL missing altogether vs having null/NaN values.

We have added an additional error message for null/NaN values which reads (for TISSUE_POSITION_COL="array_col"):

obs['array_col'] cannot have missing or NaN values when obs['assay_ontology_term_id'] is a descendant of 'EFO:0010961' (Visium Spatial Gene Expression) and uns['spatial']['is_single'] is True.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.3 Next minor CELLxGENE schema version after 5.2 curation software
Projects
None yet
Development

No branches or pull requests

3 participants