Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Differentiate between missing column and column with null/NaN values #1230

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

ejmolinelli
Copy link
Contributor

Reason for Change

Changes

  • split out check on validating tissue_position_column into a) test for column existence, and (b) test for null/NaN values.

Testing

  • nothing new

@ejmolinelli ejmolinelli requested a review from joyceyan January 30, 2025 16:24
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.89%. Comparing base (54bc35d) to head (9c2c812).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1230      +/-   ##
==========================================
+ Coverage   89.83%   89.89%   +0.06%     
==========================================
  Files          19       19              
  Lines        2184     2188       +4     
==========================================
+ Hits         1962     1967       +5     
+ Misses        222      221       -1     
Components Coverage Δ
cellxgene_schema_cli 90.85% <100.00%> (+0.08%) ⬆️
migration_assistant 91.26% <ø> (ø)
schema_bump_dry_run_genes 79.80% <ø> (ø)
schema_bump_dry_run_ontologies 99.53% <ø> (ø)

@ejmolinelli ejmolinelli force-pushed the ejmolinelli/nan-errors branch from f8a5716 to 9c2c812 Compare January 30, 2025 18:23
@ejmolinelli ejmolinelli merged commit 31a8fdb into main Jan 30, 2025
8 checks passed
@ejmolinelli ejmolinelli deleted the ejmolinelli/nan-errors branch January 30, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants