-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add includeEnvironment parameter #870 #871
Conversation
Thanks for the PR, we'll look at it. |
CI is failing? |
Apparently some tests are failing, but currently I'm not able to reproduce these failures on my local environment. I'll try to understand why they are failing and I'll try to fix them. |
I've fixed the failing tests and the formatting issues. Now it should be good. |
I've rebased the PR to solve merge conflicts. |
Thank you for the PR! |
Sorry, I cannot find your comment. Can you please link it or re-post here? |
Of course, here it is |
I'm a bit confused, the link opens this same page. Maybe your comment is private or I don't have permissions to see it? |
Yes you’re right, I hadn’t published the review. Now it should be visible! |
This PR introduce a new parameter
includeEnvironment
that by default is true.