Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make metadata environment section optional on the lockfile #870

Closed
massimeddu-sj opened this issue Sep 2, 2024 · 6 comments
Closed

Make metadata environment section optional on the lockfile #870

massimeddu-sj opened this issue Sep 2, 2024 · 6 comments

Comments

@massimeddu-sj
Copy link
Contributor

massimeddu-sj commented Sep 2, 2024

Please introduce a parameter on the plugin to enable/disable the metadata.

We currently have different developers that are running on different environments (with different jvms). Currently the lockfile is updated every time another developer generate the lockfile because the environment is changed.

We would like to have a parameter includeEnvironment that permits to enable/disable the generation of the environment metadata (as we have a parameter to disable the generation of the mavenPlugins data).

The default behavior should be the current one (includeEnvironment=true), so no breaking changes are introduced.

@massimeddu-sj massimeddu-sj changed the title Make metadata section optional on the lockfile Make metadata environment section optional on the lockfile Sep 2, 2024
massimeddu-sj added a commit to massimeddu-sj/maven-lockfile that referenced this issue Sep 2, 2024
@massimeddu-sj
Copy link
Contributor Author

Hi @monperrus please have a look at the proposed PR #871 to add this functionality. Please let me know what do you think about. Thank you!

massimeddu-sj added a commit to massimeddu-sj/maven-lockfile that referenced this issue Sep 3, 2024
massimeddu-sj added a commit to massimeddu-sj/maven-lockfile that referenced this issue Sep 6, 2024
massimeddu-sj added a commit to massimeddu-sj/maven-lockfile that referenced this issue Sep 6, 2024
@LogFlames
Copy link
Member

Merged with #871

@massimeddu-sj
Copy link
Contributor Author

massimeddu-sj commented Sep 12, 2024

Hi @LogFlames @monperrus do you have an expected date on when these changes will be released?

My team is currently relying on an internal fork with these patches, so I would like to know if an when a release is planned, so I can migrate back from the fork to the main project.

Thank you.

@LogFlames
Copy link
Member

I will look to create a release ASAP as I see no need to delay. This will however be the first release i publish, so it might take some time to initialize all accounts and for me to get the workflow running.

@monperrus
Copy link
Contributor

monperrus commented Sep 13, 2024 via email

@LogFlames
Copy link
Member

@massimeddu-sj Now we have released 5.2.0 ✨
If there are any problems or oddities, don't hesitate to write letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants