Adjusted hub upgrade database migration to show only actionable logs - #1511
Merged
Conversation
craigcomstock
marked this pull request as draft
October 15, 2024 18:12
Contributor
Author
|
|
craigcomstock
force-pushed
the
ENT-12383-3/master
branch
from
October 15, 2024 20:51
eceadc3 to
46d274d
Compare
This was referenced Oct 15, 2024
Contributor
Author
|
@cf-bottom jenkins |
Contributor
Author
|
Will wait on jenkins results before opening for review. |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/11288/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11288/ |
Contributor
Author
|
only one selenium failure, probably unrelated but I will check more closely. upgrade tests passed! |
craigcomstock
marked this pull request as ready for review
October 16, 2024 11:19
vpodzime
reviewed
Oct 16, 2024
vpodzime
left a comment
vpodzime
left a comment
Contributor
There was a problem hiding this comment.
- a trailing libre in the commit message.
And I'd split the changes into two commits -- one changing the output and a separate one messing with LD_LIBRARY_PATH.
craigcomstock
force-pushed
the
ENT-12383-3/master
branch
from
October 16, 2024 14:15
46d274d to
3fab0fa
Compare
If pg_upgrade fails it is OK because we have several other options which we try during hub package upgrade. To see any errors, run the upgrade with DEBUG=1 defined as an environment variable. Ticket: ENT-12383 Changelog: title
…ARY_PATH of previous installation" In the case of 3.21.5 (postgresql 15.6) to 3.25.0a (master, postgresql 17.0) pg_upgrade seems to work fine with the removal of LD_LIBRARY_PATH pointed at the backup. In other cases we will simply ignore pg_upgrade failures and allow the subsequent migration methods to proceed. This reverts commit e39924c.
craigcomstock
force-pushed
the
ENT-12383-3/master
branch
from
October 16, 2024 19:37
3fab0fa to
2c74496
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If pg_upgrade fails it is OK because we have several other options which we try during hub package upgrade.
It is likely that pg_upgrade will fail when upgrading major versions of postgresql during the hub package upgrade.
Sadly, since we build postgresql to link to /var/cfengine/lib (WORKDIR/lib) the pg_upgrade utility can fail due to old-bin binaries trying to use the newer libraries and missing symbols.
If we followed the pattern of placing each set of postgresql binaries, libraries, etc in a major-versioned directory this would not be an issue.
However, making that change seems too large and doesn't handle previous versions of CFEngine hub package well.
To see the errors, run the upgrade with DEBUG=1 defined as an environment variable.
Ticket: ENT-12383
Changelog: title