Moved PostgreSQL to WORKDIR/PostgreSQL/<psql-major-version> to help with hub package upgrades migration - #1510
Closed
craigcomstock wants to merge 2 commits into
Closed
Conversation
…ith hub package upgrades migration pg_upgrade will work better if we have a major-version specific directory in which libraries are contained. Without this we end up with commands like psql linked to /var/cfengine/lib/libpq.so in both old and new versions during upgrades. libpq.so can easily change in a breaking way and no amount of LD_LIBRARY_PATH can fix pg_upgrade because it checks BOTH old and new bin dirs with the same execution and has not argument to specify a different library dir for old and new versions. Ticket: ENT-12383 Changelog: title
craigcomstock
marked this pull request as draft
October 15, 2024 15:52
Contributor
Author
|
|
Contributor
Author
|
|
Contributor
Author
|
prefer #1511 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pg_upgrade will work better if we have a major-version specific directory in which libraries are contained.
Without this we end up with commands like psql linked to /var/cfengine/lib/libpq.so in both old and new versions during upgrades.
libpq.so can easily change in a breaking way and no amount of LD_LIBRARY_PATH can fix pg_upgrade because it checks BOTH old and new bin dirs with the same execution and has not argument to specify a different library dir for old and new versions.
Ticket: ENT-12383
Changelog: title