Skip to content

Conversation

Donaim
Copy link
Member

@Donaim Donaim commented Dec 24, 2024

No description provided.

@Donaim Donaim force-pushed the contig-merger branch 2 times, most recently from bd99be4 to d286cc6 Compare December 31, 2024 23:31
@Donaim Donaim changed the title Contig merger Reference-less contig stitching Dec 31, 2024
@Donaim Donaim force-pushed the contig-merger branch 8 times, most recently from 19e8143 to 88dc5ba Compare January 3, 2025 18:53
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

❌ Patch coverage is 73.91304% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.48%. Comparing base (99412d5) to head (aebd00f).
⚠️ Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
micall/core/contig_stitcher.py 70.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1221      +/-   ##
==========================================
- Coverage   87.14%   86.48%   -0.66%     
==========================================
  Files          31       31              
  Lines        7545     7223     -322     
==========================================
- Hits         6575     6247     -328     
- Misses        970      976       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Donaim Donaim force-pushed the contig-merger branch 9 times, most recently from 93f56aa to f13bdb4 Compare January 10, 2025 18:24
@Donaim Donaim force-pushed the contig-merger branch 3 times, most recently from 6eea5d3 to cdf16f2 Compare January 11, 2025 00:48
@Donaim
Copy link
Member Author

Donaim commented Jan 13, 2025

So I'm working on optimizing the stitcher.
The current profiling looks like this:

call_graph

Evidently, fractions are very slow

@Donaim
Copy link
Member Author

Donaim commented Jan 13, 2025

This is the same profiling results, after fractions have been replaced by ints:

call_graph

@Donaim Donaim force-pushed the contig-merger branch 4 times, most recently from 1d272a6 to 8e8ccba Compare January 16, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant