Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Heavy Ion Physics tag to HI records #3709

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

zlmarshall
Copy link
Contributor

For the two new HI records, we should make sure the Heavy Ion tag is included :)

@@ -5,6 +5,7 @@
},
"accelerator": "CERN-LHC",
"categories": {
"primary": "Heavy-Ion Physics",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the "categories" field is used with the simulated data only:
https://github.com/cernopendata/cernopendata-portal/blob/main/cernopendata/jsonschemas/records/record-v1.0.0.json#L107

Hence this edit should rather go to the MC record, not to the data record.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we have the data-neutral keywoard "heavy-ion physics" that people select in the faceted search: https://opendata.cern.ch/search?q=&f=keywords%3Aheavy-ion%20physics&l=list&order=desc&p=1&s=10&sort=mostrecent

So that we could add to all three records the following snippet:

    "keywords": [
      "heavy-ion physics"
    ],

If it's OK with you, I can make these changes whilst merging.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is definitely ok with me — thanks!

Adds "heavy-ion physics" keyword to the two new ATLAS HI records.for
Removes "categories" from the collision data records, leaving it only
for simulations.for

Co-authored-by: Tibor Šimko <[email protected]>
@tiborsimko tiborsimko force-pushed the HI_tag_for_ATLAS_record branch from cebb14c to 526e8f2 Compare December 16, 2024 16:04
@tiborsimko tiborsimko merged commit 526e8f2 into master Dec 16, 2024
12 checks passed
@tiborsimko tiborsimko deleted the HI_tag_for_ATLAS_record branch December 16, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants