-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: un-export namespace.ValidateBlobNamespace
#2145
Merged
rootulp
merged 7 commits into
celestiaorg:main
from
rootulp:rp/deduplicate-validate-blob-ns
Jul 27, 2023
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
976995e
refactor: de-duplicate validate blob namespace
rootulp 1ce7bf8
test: fix TestValidateBasic
rootulp 14332d2
move ValidateBlobNamespace to x/blob/types
rootulp 6da0b6a
fix godoc
rootulp 6e4c660
remove debug log
rootulp aea8eeb
refactor: isBlobNamespace
rootulp fd3c36f
Merge branch 'main' into rp/deduplicate-validate-blob-ns
rootulp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -2,6 +2,7 @@ package namespace | |||||
|
||||||
import ( | ||||||
tmrand "github.com/tendermint/tendermint/libs/rand" | ||||||
"golang.org/x/exp/slices" | ||||||
) | ||||||
|
||||||
func RandomBlobNamespaceID() []byte { | ||||||
|
@@ -22,11 +23,9 @@ func RandomBlobNamespaceWithPRG(prg *tmrand.Rand) Namespace { | |||||
for { | ||||||
id := RandomBlobNamespaceIDWithPRG(prg) | ||||||
namespace := MustNewV0(id) | ||||||
err := namespace.ValidateBlobNamespace() | ||||||
if err != nil { | ||||||
continue | ||||||
if isBlobNamespace(namespace) { | ||||||
return namespace | ||||||
} | ||||||
return namespace | ||||||
} | ||||||
} | ||||||
|
||||||
|
@@ -36,3 +35,25 @@ func RandomBlobNamespaces(rand *tmrand.Rand, count int) (namespaces []Namespace) | |||||
} | ||||||
return namespaces | ||||||
} | ||||||
|
||||||
// isBlobNamespace returns an true if this namespace is a valid user-specifiable | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
// blob namespace. | ||||||
func isBlobNamespace(ns Namespace) bool { | ||||||
if ns.IsReserved() { | ||||||
return false | ||||||
} | ||||||
|
||||||
if ns.IsParityShares() { | ||||||
return false | ||||||
} | ||||||
|
||||||
if ns.IsTailPadding() { | ||||||
return false | ||||||
} | ||||||
|
||||||
if !slices.Contains(SupportedBlobNamespaceVersions, ns.Version) { | ||||||
return false | ||||||
} | ||||||
|
||||||
return true | ||||||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[note to reviewers] this function was renamed per the comment in #2143
I thought the original name was clear but I'm open to alternative naming suggestions.