refactor!: un-export namespace.ValidateBlobNamespace
#2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
added
the
refactor
Codecov Report
@@ Coverage Diff @@
## main #2145 +/- ##
==========================================
- Coverage 24.41% 24.40% -0.01%
==========================================
Files 126 126
Lines 14300 14302 +2
==========================================
Hits 3491 3491
- Misses 10448 10450 +2
Partials 361 361
|
cmwaters
previously approved these changes
Jul 24, 2023
evan-forbes
reviewed
Jul 24, 2023
|
@rootulp, could you open similar PR to celeria-node? I think we may have similar issue, as our code is mostly a port. |
rootulp
commented
Jul 24, 2023
| // validateVersion returns an error if the version is not supported. | ||
| func validateVersion(version uint8) error { | ||
| // validateVersionSupported returns an error if the version is not supported. | ||
| func validateVersionSupported(version uint8) error { |
There was a problem hiding this comment.
[note to reviewers] this function was renamed per the comment in #2143
I thought the original name was clear but I'm open to alternative naming suggestions.
rootulp
changed the title
namespace.ValidateBlobNamespace
As far as I can see, celestia-node only has one reference to |
|
@rootulp, I mean the slice.Contains if should also be added to our validate function |
evan-forbes
reviewed
Jul 25, 2023
rootulp
changed the title
namespace.ValidateBlobNamespacenamespace.ValidateBlobNamespace
evan-forbes
approved these changes
Jul 26, 2023
cmwaters
approved these changes
Jul 27, 2023
| @@ -36,3 +35,25 @@ func RandomBlobNamespaces(rand *tmrand.Rand, count int) (namespaces []Namespace) | |||
| } | |||
| return namespaces | |||
| } | |||
|
|
|||
| // isBlobNamespace returns an true if this namespace is a valid user-specifiable | |||
There was a problem hiding this comment.
Suggested change
| // isBlobNamespace returns an true if this namespace is a valid user-specifiable | |
| // isBlobNamespace returns true if this namespace is a valid user-specifiable |
rootulp
added a commit
that referenced
this pull request
Aug 14, 2023
Closes #2143 De-duplicate `ValidateBlobNamespace` and export it from `x/blob/types` package. The namespace package needs to define its own `isBlobNamespace` because it can't import `ValidateBlobNamespace` from `x/blob/types` as that would introduce a circular dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2143
De-duplicate
ValidateBlobNamespaceand export it fromx/blob/typespackage. The namespace package needs to define its ownisBlobNamespacebecause it can't importValidateBlobNamespacefromx/blob/typesas that would introduce a circular dependency.