fix: type check in equality operator, no comparison should raise now

cdown · Nov 2, 2023 · c99d759 · c99d759
1 parent df8de24
commit c99d759
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/srt.py b/srt.py
@@ -126,7 +126,7 @@ def __hash__(self):
         return hash(frozenset(vars(self).items()))
 
     def __eq__(self, other):
-        return other and vars(self) == vars(other)
+        return isinstance(other, Subtitle) and vars(self) == vars(other)
 
     def __lt__(self, other):
         return (self.start, self.end, self.index) < (

diff --git a/tests/test_srt.py b/tests/test_srt.py
@@ -242,8 +242,9 @@ def test_subtitle_inequality(sub_1):
 
 
 @given(subtitles())
-def test_subtitle_inequality_to_none(sub_1):
+def test_subtitle_inequality_to_non_matching_type(sub_1):
     assert sub_1 != None
+    assert sub_1 != 1
 
 
 @given(subtitles())