fix: subtitle inequality to None

cdown · Nov 2, 2023 · df8de24 · df8de24
1 parent 434d0c1
commit df8de24
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/srt.py b/srt.py
@@ -126,7 +126,7 @@ def __hash__(self):
         return hash(frozenset(vars(self).items()))
 
     def __eq__(self, other):
-        return vars(self) == vars(other)
+        return other and vars(self) == vars(other)
 
     def __lt__(self, other):
         return (self.start, self.end, self.index) < (

diff --git a/tests/test_srt.py b/tests/test_srt.py
@@ -241,6 +241,11 @@ def test_subtitle_inequality(sub_1):
     assert sub_1 != sub_2
 
 
+@given(subtitles())
+def test_subtitle_inequality_to_none(sub_1):
+    assert sub_1 != None
+
+
 @given(subtitles())
 def test_subtitle_from_scratch_equality(subtitle):
     srt_block = subtitle.to_srt()