Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using rack v3 #188

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ jobs:
protoc:
runs-on: ubuntu-latest
steps:
- uses: arduino/setup-protoc@v1
- uses: arduino/setup-protoc@v3
with:
version: '3.x'
version: '29.3'
- uses: actions/checkout@v2
- uses: actions/setup-go@v2
with:
go-version: ^1.16
- run: go install google.golang.org/protobuf/cmd/protoc-gen-go
go-version: 1.24.1
- run: go install google.golang.org/protobuf/cmd/protoc-gen-go@1.36.5
- run: protoc -I=. --go_out=pb --go_opt=paths=source_relative --ruby_out=ruby/lib/umbra/pb ./umbra.proto
- run: git add . && git diff --staged --exit-code

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,13 @@ A minimal rack application using `umbra` would look like this:
```ruby
# /config.ru
require 'rack'
require 'rack/lobster'
require 'rackup/lobster'
require 'umbra'

Umbra.configure

use Umbra::Middleware
run Rack::Lobster.new
run Rackup::Lobster.new

```

Expand Down
55 changes: 19 additions & 36 deletions pb/umbra.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions ruby/config.ru
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ lib = File.expand_path("lib", __dir__)
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)

require "rack"
require "rack/lobster"
require "rackup/lobster"
require "puma"
require "umbra"
require "pry"

Umbra.configure

use Umbra::Middleware
run Rack::Lobster.new
run Rackup::Lobster.new
2 changes: 2 additions & 0 deletions ruby/lib/umbra.rb
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ def reset!
private

def request_body(env)
return nil unless env.key?("rack.input")

io = env.fetch("rack.input")
io.rewind
body = io.read
Expand Down
2 changes: 2 additions & 0 deletions ruby/lib/umbra/config.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
require "logger"

module Umbra
class Config
attr_accessor :publisher, :request_selector, :encoder, :error_handler, :redis_options, :logger
Expand Down
16 changes: 6 additions & 10 deletions ruby/lib/umbra/pb/umbra_pb.rb

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ruby/lib/umbra/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module Umbra
VERSION = "0.3.0"
VERSION = "0.4.0"
end
4 changes: 2 additions & 2 deletions ruby/spec/integration_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
allow(Umbra).to receive(:redis).and_return(redis)
end

let(:app) { Rack::Builder.parse_file("config.ru").first }
let(:app) { Rack::Builder.parse_file("config.ru") }
let(:redis) do
Class.new {
attr_reader :messages
Expand Down Expand Up @@ -39,7 +39,7 @@ def publish(channel, message)
expect(redis.messages.count).to eq(1)
end

fit "publishes the expected protobuf message" do
it "publishes the expected protobuf message" do
post "/", "request-body"

sleep(0.1)
Expand Down
1 change: 1 addition & 0 deletions ruby/umbra-rb.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "pry"
spec.add_development_dependency "rake", "~> 13.0"
spec.add_development_dependency "rspec", "~> 3.0"
spec.add_development_dependency "rackup", ">=2", "< 3"
spec.add_development_dependency "rack-test"
spec.add_development_dependency "puma"

Expand Down
Loading