-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix using rack v3 #188
base: master
Are you sure you want to change the base?
Fix using rack v3 #188
Conversation
32eaee7
to
28b16fd
Compare
ruby/umbra-rb.gemspec
Outdated
@@ -40,5 +40,6 @@ Gem::Specification.new do |spec| | |||
spec.add_dependency "redis", "~> 4.1" | |||
spec.add_dependency "google-protobuf", "~> 3" | |||
spec.add_dependency "rack", ">= 2", "< 4" | |||
spec.add_dependency "rackup", ">=2", "< 3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only a dev/test dependency, so it can be moved to add_development_dependency
.
I have to admit some ignorance when working with rack, especially when it's being used inside a gem. What's the purpose of the |
It's only used for a Lobster server whilst testing.
|
69ce4de
to
c2bc71d
Compare
1fbed39
to
50237db
Compare
These changes get the Gem running locally again, with a few tune ups and one actual fix: