Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Getting started section #1460

Merged

Conversation

oduameh
Copy link
Contributor

@oduameh oduameh commented May 30, 2024


  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

@oduameh
Copy link
Contributor Author

oduameh commented May 30, 2024

This PR fixes https://input-output.atlassian.net/browse/MK-5053
and closes oduameh#1

@olgahryniuk
Copy link
Collaborator

I think this PR needs renaming @oduameh to 'Getting started review' or something similar.

@oduameh oduameh changed the title Merge pull request #1447 from input-output-hk/lc/remove-benchmark-fees Merge pull request #1447 Getting started review Jun 4, 2024
@oduameh
Copy link
Contributor Author

oduameh commented Jun 4, 2024

I think this PR needs renaming @oduameh to 'Getting started review' or something similar.

I agree,updated

@locallycompact locallycompact force-pushed the MK-5053-Getting-started-Hydra branch from 2d0d14f to 9cba978 Compare June 4, 2024 16:14
…e-benchmark-fees

Remove redundant fee calculation.

<!-- Describe your change here -->

---

<!-- Consider each and tick it off one way or the other -->
* [ ] CHANGELOG updated or not needed
* [ ] Documentation updated or not needed
* [ ] Haddocks updated or not needed
* [ ] No new TODOs introduced or explained herafter
@locallycompact locallycompact force-pushed the MK-5053-Getting-started-Hydra branch from 9cba978 to 0a4d7fb Compare June 4, 2024 16:18
@locallycompact locallycompact changed the title Merge pull request #1447 Getting started review Review Getting started section Jun 4, 2024
@ffakenz ffakenz merged commit 66f20ae into cardano-scaling:master Jun 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants