Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support VM disk resize without reboot (from Incus) #14211

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Support VM disk resize without reboot (from Incus) #14211

wants to merge 10 commits into from

Conversation

kadinsayani
Copy link
Contributor

@kadinsayani kadinsayani commented Oct 4, 2024 •
edited
Loading

This PR adds support for resizing (growing) VM disks without rebooting, when using ZFS, LVM or Ceph storage backends.

Resolves #13311.

@kadinsayani kadinsayani force-pushed the 13311-support-growing-vm-disk-size-without-reboot branch from c32cf54 to 09b040b Compare October 7, 2024 17:25
@kadinsayani kadinsayani marked this pull request as ready for review October 7, 2024 18:20
@kadinsayani kadinsayani force-pushed the 13311-support-growing-vm-disk-size-without-reboot branch from 5141575 to 4646696 Compare October 7, 2024 20:56
@kadinsayani kadinsayani mentioned this pull request Oct 7, 2024
Open
@kadinsayani kadinsayani force-pushed the 13311-support-growing-vm-disk-size-without-reboot branch from 4646696 to 39f4b7a Compare October 7, 2024 21:03
@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Oct 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

Heads up @mionaalex - the "Documentation" label was applied to this issue.

@kadinsayani kadinsayani force-pushed the 13311-support-growing-vm-disk-size-without-reboot branch 2 times, most recently from bef2c1b to eb1b3a6 Compare October 8, 2024 02:03
@kadinsayani kadinsayani mentioned this pull request Oct 8, 2024
Open
@kadinsayani kadinsayani force-pushed the 13311-support-growing-vm-disk-size-without-reboot branch from eb1b3a6 to 41533d9 Compare October 8, 2024 02:19
@simondeziel
Copy link
Member

What would prevent growing live the .raw file backing a QEMU on another storage driver? Or maybe that was left for another day/PR?

@tomponline
Copy link
Member

What would prevent growing live the .raw file backing a QEMU on another storage driver? Or maybe that was left for another day/PR?

I'd like it if we could explore adding suppport for that, we support growing the raw disk file offline, so not sure if there is a reason we cant do it online?

@tomponline
Copy link
Member

Needs a rebase too please

@kadinsayani kadinsayani force-pushed the 13311-support-growing-vm-disk-size-without-reboot branch from 41533d9 to 877ed7d Compare October 9, 2024 16:16
@kadinsayani
Copy link
Contributor Author

@simondeziel @tomponline re: online disk resize

I don't see an issue with adding online disk resizing for ceph. RBD has an exclusive lock feature and supports online resizing with RBD client kernel > 3.10.

@simondeziel
Copy link
Member

Thanks for checking on ceph RBD live resize capabilities! As Tom mentioned, we can already grow plain .raw file while offline so maybe we could do that live too now that there's a mechanism to notify QEMU about the bigger backing file.

@kadinsayani kadinsayani force-pushed the 13311-support-growing-vm-disk-size-without-reboot branch from 877ed7d to b3f97a5 Compare October 14, 2024 21:50
@kadinsayani
Copy link
Contributor Author

@tomponline rebased and good to go. Do we want to include support for live resizing ceph disks with this PR or open up a separate issue and save it for later?

@tomponline
Copy link
Member

@tomponline rebased and good to go. Do we want to include support for live resizing ceph disks with this PR or open up a separate issue and save it for later?

Lets try and do it as part of this PR. And then we can add a single API extension.

stgraber and others added 9 commits October 22, 2024 14:40
@stgraber @kadinsayani
lxd/storage/lvm: Allow live resize
1b9d7a1 
Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit d78b0a89e61afbb73790c561653acda1d79d6f9f)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
@stgraber @kadinsayani
lxd/storage/zfs: Allow online resize of ZFS block volumes
46df0e8 
Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit 0d8561e95d0f0eac1f4a5c497916f950dc6a6db1)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
@stgraber @kadinsayani
lxd/device/disk: Add callback on resize
da06535 
Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit c13e9298cc6341bdb522b91ea53bbb91e6865eb1)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
@stgraber @kadinsayani
lxd/instance/drivers/qmp: Add resize handling
51b4d7d 
Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit 17fb18ef07b1369f59bc9181e9657f7c6e1ee3fa)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
@stgraber @kadinsayani
lxd/instance/qemu: Add disk resize handling
da75a8c 
Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit de3ea2ec6e7ac112ad0e91c0c08339adbae368b1)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
@kadinsayani
lxd/storage/drivers: Add named results to thinPoolVolumeUsage
21293bb 
Signed-off-by: Kadin Sayani <[email protected]>
@kadinsayani
lxd/storage/drivers: Simplify early return in copyThinpoolVolume
b11f401 
Signed-off-by: Kadin Sayani <[email protected]>
@stgraber @kadinsayani
lxd/api_internal: Add API to notify volume resizes
928f474 
Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit 9df531e5ee9a5d0267cd74f15312d9ac031315da)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
@stgraber @kadinsayani
lxd/storage/backend: Notify instances following block custom volume r…
5f8b6d0 
…esize

Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit 81f9c4b915830322871bb49d6f04f3009f63d01a)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
@kadinsayani kadinsayani force-pushed the 13311-support-growing-vm-disk-size-without-reboot branch 2 times, most recently from 257be7c to 86b38f5 Compare October 22, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support growing the VM disk size without needing to reboot the VM
4 participants
@kadinsayani @simondeziel @tomponline @stgraber