Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/storage-vm: Add test for live resizing of VM disks with zfs or lvm pool driver #310

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kadinsayani
Copy link
Contributor

This PR adds a test for canonical/lxd#14211. The test depends on presence of the feature which is indicated by the api extensions vm_zfs_storage_disk_live_resize and vm_lvm_storage_disk_live_resize.

tests/storage-vm Fixed Show fixed Hide fixed
tests/storage-vm Fixed Show fixed Hide fixed
tests/storage-vm Fixed Show fixed Hide fixed
tests/storage-vm Fixed Show fixed Hide fixed
tests/storage-vm Fixed Show fixed Hide fixed
tests/storage-vm Outdated Show resolved Hide resolved
tests/storage-vm Outdated Show resolved Hide resolved
tests/storage-vm Outdated Show resolved Hide resolved
@kadinsayani kadinsayani force-pushed the vm-disk-resize-tests branch 4 times, most recently from db901b4 to aa33380 Compare October 9, 2024 16:56
tests/storage-vm Outdated Show resolved Hide resolved
simondeziel
simondeziel previously approved these changes Oct 9, 2024
Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all storage drivers are to grow support for live resize then the extension name will change before landing in LXD.

As for the testing logic, it looks good to me even if I've not seen it in action for the LIVE_GROWING_SUPPORTED=1 case.

@simondeziel simondeziel dismissed their stale review October 18, 2024 14:33

Let's wait for live resize support for all storage drivers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants