Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove systemd config on relation departed #22

Merged

Conversation

Thanhphan1147
Copy link
Collaborator

When agent relation is removed the systemd config file is not removed, we should clean it up after stopping the service

Checklist

@Thanhphan1147 Thanhphan1147 added the trivial This is a trivial PR label Feb 8, 2024
@Thanhphan1147 Thanhphan1147 requested a review from a team as a code owner February 8, 2024 15:35
@Thanhphan1147 Thanhphan1147 changed the title Remove systemd config and hc file on relation departed Remove systemd config on relation departed Feb 8, 2024
arturo-seijas
arturo-seijas previously approved these changes Feb 8, 2024
src/agent_observer.py Outdated Show resolved Hide resolved
Copy link
Contributor

Test coverage for 4e53cdf

Name                    Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------
src/agent_observer.py      42      0      4      0   100%
src/charm.py               53      0      6      0   100%
src/charm_state.py         59      4      8      1    93%   114, 172-174
src/service.py             95      2     14      5    94%   106->118, 133, 165, 188->193, 191->188
-------------------------------------------------------------------
TOTAL                     249      6     32      6    96%

Static code analysis report

Run started:2024-02-14 08:44:40.614359

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 1062
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@Thanhphan1147 Thanhphan1147 merged commit 6f7f297 into main Feb 14, 2024
20 checks passed
@Thanhphan1147 Thanhphan1147 deleted the remove_systemd_config_and_hc_file_on_relation_departed branch February 14, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Libraries: OK trivial This is a trivial PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants