merge stop and remove config file into reset() function

src/agent_observer.py

@@ -89,9 +89,8 @@ def _on_agent_relation_changed(self, _: ops.RelationChangedEvent) -> None:
     def _on_agent_relation_departed(self, _: ops.RelationDepartedEvent) -> None:
         """Handle agent relation departed event."""
         try:
-            self.jenkins_agent_service.stop()
+            self.jenkins_agent_service.reset()
         except service.ServiceStopError:
             self.charm.unit.status = ops.BlockedStatus("Error stopping the agent service")
             return
-        self.jenkins_agent_service.clear_service_configuration()
         self.charm.unit.status = ops.BlockedStatus("Waiting for config/relation.")

src/service.py

@@ -164,8 +164,8 @@ def restart(self) -> None:
         if not self._startup_check():
             raise ServiceRestartError("Error waiting for the agent service to start")
 
-    def stop(self) -> None:
-        """Stop the agent service.
+    def reset(self) -> None:
+        """Stop the agent service and clear its configuration file.
 
         Raises:
             ServiceStopError: if systemctl stop returns a non-zero exit code.
@@ -175,9 +175,6 @@ def stop(self) -> None:
         except systemd.SystemdError as exc:
             logger.error("service %s failed to stop", AGENT_SERVICE_NAME)
             raise ServiceStopError(f"service {AGENT_SERVICE_NAME} failed to stop") from exc
-
-    def clear_service_configuration(self) -> None:
-        """Clear the service's configuration file."""
         config_file = Path(f"{SYSTEMD_SERVICE_CONF_DIR}/override.conf")
         config_file.unlink(missing_ok=True)