Fix child notification #9235
Merged
Fix child notification #9235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Examples: https://camptocamp.github.io/ngeo/refs/pull/9235/merge/examples/
Storybook: https://camptocamp.github.io/ngeo/refs/pull/9235/merge/storybook/
API help: https://camptocamp.github.io/ngeo/refs/pull/9235/merge/api/apihelp/apihelp.html
API documentation: https://camptocamp.github.io/ngeo/refs/pull/9235/merge/apidoc/
sbrunner
force-pushed
the
fix-child-notification
branch
from
7d1431f to
f83ab1e
Compare
vuilleumierc
approved these changes
Oct 10, 2023
sbrunner
force-pushed
the
fix-child-notification
branch
from
f83ab1e to
ad10eed
Compare
llienher
approved these changes
Oct 10, 2023
sbrunner
force-pushed
the
fix-child-notification
branch
3 times, most recently
from
f1fa90d to
2e75506
Compare
sbrunner
force-pushed
the
fix-child-notification
branch
from
2e75506 to
e265d02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GEO-6859
Currently:
The parent get a refreshState
=> getCalculateState on the parent
=> getCalculateState=>'' on the children becaude the children are not initialized (getState=>'off')
Then the child get a refreshState
=> getCalculateState on the child => 'off' because the children are initialised
=> no notification to the parent because the state didn't changed...