Fix notification on child value changed

camptocamp · Oct 10, 2023 · ad10eed · ad10eed
1 parent 6d55e5c
commit ad10eed
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/layertree/Controller.js b/src/layertree/Controller.js
@@ -204,7 +204,7 @@ export function LayertreeController($scope, $rootScope, $attrs) {
 /**
  * Return the current state.
  *
- * @returns {string} 'on', 'off', 'indeterminate'.
+ * @returns {string} 'on', 'off', 'indeterminate', or '' if the children are not initialized.
  */
 LayertreeController.prototype.getState = function () {
   return this.state_;
@@ -302,7 +302,7 @@ LayertreeController.prototype.refreshState = function (opt_onChild, opt_broadcas
 /**
  * Return the current state, calculate on all its children recursively.
  *
- * @returns {string} 'on', 'off' or 'indeterminate'.
+ * @returns {string} 'on', 'off', 'indeterminate', or '' if the children are not initialized.
  */
 LayertreeController.prototype.getCalculateState = function () {
   const group = /** @type {import('gmf/themes').GmfGroup} */ (this.node);
@@ -314,7 +314,7 @@ LayertreeController.prototype.getCalculateState = function () {
   /** @type {string} */
   let previousChildState;
   this.children.some((child) => {
-    childState = child.getCalculateState();
+    childState = child.getState();
     if (previousChildState) {
       if (previousChildState !== childState) {
         childState = 'indeterminate';