-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] refines the auth flows #76
Conversation
da9a056
to
5a73558
Compare
a36d7aa
to
1b3a596
Compare
94888fe
to
aee6072
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good pragya! i just had some minor nits, but otherwise everything looks great - major improvement to the auth flows!
src/app/(auth)/login/page.tsx
Outdated
setEmailError(validEmail(email) ? '' : 'Email not found.'); | ||
setPasswordError(password !== '' ? '' : 'Password is incorrect.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also get rid of the periods for these error messages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OH also, are you still down to implement these error checks like we had mentioned the other day?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOOKS AMAZING PRAGYA! THANKS FOR ENHANCING THE AUTH FLOWS :))
🎋 Description
🌴 What's new in this PR
This PR:
🌲 Screenshots
(1) password in confirm password input does not match the original
(2) email for the account already exists
(3) new password is not the same as old password (working on screenshot 🔨)
🌳 How to review
🌱 Next steps
🔗 Relevant Links
ℹ️ Online sources
https://github.com/orgs/supabase/discussions/1282#discussioncomment-5230475
🪴 Related PRs
CC: @varortz