Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[style] updates styling for all auth flows #79

Merged
merged 17 commits into from
May 20, 2024

Conversation

pragyakallanagoudar
Copy link
Collaborator

@pragyakallanagoudar pragyakallanagoudar commented Apr 16, 2024

🎋 Description

🌴 What's new in this PR

This PR updates the styling for all of the auth flows to match Kyrene's newest designs! This involves changing the font to Inter, changing the div for all of the auth screens to have a drop shadow instead of a solid blue border, and other miscellaneous changes like updating spacing, sizing, and adding icons.

i am so cool hehe

🌲 Screenshots

Screenshot 2024-04-18 at 9 00 29 PM Screenshot 2024-04-18 at 9 00 47 PM Screenshot 2024-04-18 at 9 01 06 PM Screenshot 2024-04-18 at 9 01 24 PM Screenshot 2024-04-18 at 9 01 56 PM

🌳 How to review

Run the app, and then navigate to the /login, /signup, and /forgot-password flows. Compare them side-by-side with the Figma to make sure they match!

🌱 Next steps

N/A

🔗 Relevant Links

ℹ️ Online sources

🪴 Related PRs

#76

CC: @varortz @kyrenetam

Copy link

linear bot commented Apr 16, 2024

@pragyakallanagoudar pragyakallanagoudar changed the title [DRAFT] [refactor] updates styling for all auth flows [DRAFT] [style] updates styling for all auth flows Apr 16, 2024
@varortz varortz self-requested a review April 17, 2024 19:27
src/app/(auth)/styles.tsx Outdated Show resolved Hide resolved
src/app/(auth)/styles.tsx Outdated Show resolved Hide resolved
src/app/(auth)/styles.tsx Outdated Show resolved Hide resolved
src/styles/fonts.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@ccatherinetan ccatherinetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good! just a couple questions/catches

@pragyakallanagoudar pragyakallanagoudar changed the title [DRAFT] [style] updates styling for all auth flows [style] updates styling for all auth flows Apr 19, 2024
@pragyakallanagoudar pragyakallanagoudar marked this pull request as ready for review April 19, 2024 04:17
@jinkang-0 jinkang-0 force-pushed the pragya/ijp-103-update-the-styling-for-all-auth-flows branch from f42592d to f612237 Compare May 19, 2024 04:35
src/lib/icons.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@ccatherinetan ccatherinetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to access the reset password page b/c the forgot password page reroutes to the vercel app, but the rest is looking good! added a few minor nits

Copy link
Contributor

@ccatherinetan ccatherinetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once we decide if we're going to add the reset-password to CONFIG and if we're planning to change the font-weight for the Forgot Password/Reset Password flow, it looks good to merge !

Copy link
Collaborator

@varortz varortz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU PRAGYA FOR FINISHING OFF OUR STYLING & THANK YOU JINKANG FOR REBASING!!

@varortz varortz merged commit 2b322e0 into main May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants