-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assembly and genbank updates #579
Draft
dpark01
wants to merge
19
commits into
master
Choose a base branch
from
dp-ncbi
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
assemble_refbased
orrefine_assembly_with_aligned_reads
) will now trim the edges of ambiguous bases according to a "3rules" criteria used in NCBI's VADR script "fasta-trim-terminal-ambigs.pl". This is to satisfy submission requirements enforced by table2asn which fail sequences with too much ambiguous content at the edges.scaffold_and_refine_multitaxa
, save them in files that use dashes instead of colons as delimiters in the filenames, as the colons are incompatible with Singularity.utils.rename_file
to be more portable (was not working with miniwdl's implementation)genbank_single
, update more output filenames to be consistently named so we can more easily group them together.align_and_count
, bugfix for empty input bamsFastqToUBAM
, add knobs for ram and disk size and increase defaults