Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Configuration Processing #6

Merged
merged 4 commits into from
May 13, 2020

Conversation

gwaybio
Copy link
Member

@gwaybio gwaybio commented May 13, 2020

As I was progressing the recipe to the aggregate profiling step, I recognized that it is very difficult to follow all the directories and locations of necessary files.

We need to strike a balance between modularity and overburdening our users. Since we are working towards a unified file structure in regular Cell Painting experiments (see cytomining/profiling-handbook#54 (comment)) it makes sense to expect certain files and directory structure to never change. This removes unnecessary options from our users.

If in the rare event that CellProfiler output files change save locations after a Pooled Cell Painting image analysis pipeline, then we will have to revisit this structure and decision. For now, it makes development easier.

@gwaybio gwaybio requested a review from ErinWeisbart May 13, 2020 16:34
@ErinWeisbart
Copy link
Member

I understand that the convention for paths going forward will be pathlib.Path. The goal is to remove unnecessary f-strings? What about situations where the .csv name has a variable in it?Would the format be something like: pathlib.Path(output_folder, f"metadata_{site}.tsv.gz")

@gwaybio
Copy link
Member Author

gwaybio commented May 13, 2020

The goal is to remove unnecessary f-strings?

Anything unnecessary should be removed 😄

Would the format be something like: pathlib.Path(output_folder, f"metadata_{site}.tsv.gz")

Yep, this is exactly right

@gwaybio gwaybio merged commit acd847b into broadinstitute:master May 13, 2020
@gwaybio gwaybio deleted the reorganize-config branch May 13, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants