AN-735 WDL 1.1: gpu requirement attribute #7821
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aednichols
approved these changes
Nov 5, 2025
| If `true`, Cromwell will attempt to ensure that the task can run in an environment with GPU support. The task will be | ||
| failed if we can't confirm a GPU is available. | ||
|
|
||
| - Google Cloud: Cromwell will attempt to examine other runtime attributes such as `gpuCount`, `gpuType`, `predefinedMachineType` to determine whether the task is configured to use a GPU, and fail the task if it is not. |
There was a problem hiding this comment.
It would be good to include detail that answers the following user concern:
I use GPUs on Batch, are you saying I need to go through all my WDLs and add
gpu: true?! 😖
| val supportsGpu: Boolean = | ||
| machineType.toLowerCase.contains("nvidia") || | ||
| machineType.toLowerCase.contains("gpu") || | ||
| machineType.toLowerCase.matches("^g[0-9]*-.*") |
There was a problem hiding this comment.
e.g. a2-highgpu-1g
Suggested change
| machineType.toLowerCase.matches("^g[0-9]*-.*") | |
| machineType.toLowerCase.matches("^[ga][0-9]*-.*") |
There was a problem hiding this comment.
That machine a2-highgpu-1g is covered by the line above, though, .contains("gpu"), right?
There was a problem hiding this comment.
Oh I see, I didn't think of that. Disregard if you don't feel it's necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
gpuruntime attribute required by WDL 1.1. (spec)This check is implemented in two steps:
JobPreparationActorand tasks are failed if they require GPU and are running on a backend that doesn't support it.*BatchRuntimeAttributescreation.Release Notes Confirmation
CHANGELOG.mdCHANGELOG.mdin this PRCHANGELOG.mdbecause it doesn't impact community usersTerra Release Notes