[AN-142] Adding cost centaur test #7685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucymcnatt
commented
Feb 5, 2025
| } yield () | ||
| } | ||
|
|
||
| def validateNoCost(submittedWorkflow: SubmittedWorkflow): Test[Unit] = |
There was a problem hiding this comment.
maybe overkill, but I also added a test to verify that the cost is 0 when a workflow is call-cached
lucymcnatt
commented
Feb 5, 2025
| @@ -0,0 +1,17 @@ | |||
| In order to run a Cromwell instance locally, there are the some prerequisites: | |||
There was a problem hiding this comment.
This is just a start from what I can remember, feel free to add/edit!
jgainerdewar
reviewed
Feb 5, 2025
centaur/src/main/resources/standardTestCases/cacheBetweenWF/cacheBetweenWFNoCost.wdl
Outdated
Show resolved
Hide resolved
centaur/src/main/resources/standardTestCases/recursive_imports/recursive_imports_cost.options
Outdated
Show resolved
Hide resolved
| } yield () | ||
| } | ||
|
|
||
| def validateNoCost(submittedWorkflow: SubmittedWorkflow): Test[Unit] = |
| @@ -337,6 +357,15 @@ object TestFormulas extends StrictLogging { | |||
| case _ => Test.invalidTestDefinition("Configuration not supported by PapiUpgradeTest", workflowDefinition) | |||
| } | |||
|
|
|||
| def runSuccessfulWorkflowAndVerifyCost( | |||
There was a problem hiding this comment.
Did you consider updating the existing test format to optionally check cost (if it's provided in the test config)?
aednichols
reviewed
Feb 5, 2025
jgainerdewar
approved these changes
Feb 6, 2025
|
Approving assuming we can get the tests passing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release Notes Confirmation
CHANGELOG.mdCHANGELOG.mdin this PRCHANGELOG.mdbecause it doesn't impact community usersTerra Release Notes