MSRV(1.64): Use core::ffi::{c_char, c_int, c_uint, CStr} & simplify CI.
#1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansmith
force-pushed
the
b/safer-int
branch
from
34a123e to
f8db53d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1829 +/- ##
==========================================
+ Coverage 96.70% 96.71% +0.01%
==========================================
Files 145 144 -1
Lines 20763 20731 -32
Branches 244 244
==========================================
- Hits 20079 20051 -28
+ Misses 650 646 -4
Partials 34 34 ☔ View full report in Codecov by Sentry. |
briansmith
force-pushed
the
b/safer-int
branch
from
f8db53d to
65c8fe3
Compare
briansmith
changed the title
core::ffi::{c_int,c_uint}.core::ffi::{c_int,c_uint}.
briansmith
force-pushed
the
b/safer-int
branch
9 times, most recently
from
e249bfd to
aaa9ff9
Compare
briansmith
changed the title
core::ffi::{c_int,c_uint}.core::ffi::{c_char, c_int, c_uint, CStr} & simplify CI.
briansmith
force-pushed
the
b/safer-int
branch
2 times, most recently
from
ed90306 to
f1455ee
Compare
* Use core::ffi::{c_int, c_uint} and remove our polyfills,
eliminating libc as a dev-dependency.
* Somplify CI configuration for symbol prefixing since 1.64.0 has
llvm-tools-preview.
* Use `core::ffi::CStr` in aarch64-apple-* feature detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use these after the recent MSRV bump.