Remove libc dependency. #1825
Closed
Remove libc dependency. #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `core::ffi` instead of `libc`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1825 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 136 135 -1
Lines 20695 20677 -18
Branches 226 226
=======================================
- Hits 19870 19853 -17
Misses 791 791
+ Partials 34 33 -1 ☔ View full report in Codecov by Sentry. |
briansmith
commented
Feb 29, 2024
| @@ -177,18 +177,12 @@ untrusted = { version = "0.9" } | |||
| [target.'cfg(any(target_arch = "x86",target_arch = "x86_64", all(any(target_arch = "aarch64", target_arch = "arm"), any(target_os = "android", target_os = "fuchsia", target_os = "linux", target_os = "windows"))))'.dependencies] | |||
| spin = { version = "0.9.8", default-features = false, features = ["once"] } | |||
|
|
|||
| [target.'cfg(all(any(target_os = "android", target_os = "linux"), any(target_arch = "aarch64", target_arch = "arm")))'.dependencies] | |||
| libc = { version = "0.2.148", default-features = false } | |||
|
|
|||
There was a problem hiding this comment.
getauxval is provided by libc so if we're using getauxval we might as well keep using the libc crate so that it will handle the linking. However, if we keep using libc on these targets, we should limit the cfg to where we actually use libc::getauxval.
|
Replaced by PR #1829. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
core::ffiinstead oflibc.