Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert signing config for release keeping the development (debug) #649

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Revert signing config for release keeping the development (debug) #649

merged 1 commit into from
Oct 4, 2023

Conversation

ademar111190
Copy link
Collaborator

@ademar111190 ademar111190 commented Oct 4, 2023 •
edited
Loading

  • Reverts the sign-in config for release made on my last PR Add signing config #623
    • @roeierez will be signing release builds for the store manually
    • Release builds made by CI are using the default debug config
  • Keep the debug (renamed to development) config
    • This keeps the ability of the team to make debug builds with working integrations

Manually triggered https://github.com/breez/c-breez/actions/runs/6407131491 to see if everything is working

@ademar111190 ademar111190 requested a review from a team October 4, 2023 14:03
@ademar111190 ademar111190 self-assigned this Oct 4, 2023
@erdemyerebasmaz erdemyerebasmaz mentioned this pull request Oct 4, 2023
Merged
@erdemyerebasmaz erdemyerebasmaz merged commit 8a532ce into main Oct 4, 2023
0 of 2 checks passed
@erdemyerebasmaz erdemyerebasmaz deleted the aa/signing-config-development branch November 16, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeierez roeierez roeierez approved these changes

Assignees

@ademar111190 ademar111190

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ademar111190 @roeierez @erdemyerebasmaz