Do not display LSP cannot open channel message when account is disconnected #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nected Use AccountState.connectionStatus switch case to display StatusText widgets - Get AccountState & LspState from parent widget Improve readability in ReceivableBTCBox by using isChannelOpeningAvailable variable - Passing OpeningFeeParams to FeeMessage when channel opening is available Make _loadingMessage empty string by default Correct typos in - isChannelOpeningAvailiable variable - annimated_loader_dialog file name
roeierez
requested changes
Oct 4, 2023
android/app/build.gradle
Outdated
| signingConfig signingConfigs.release | ||
| // TODO: Add your own signing config for the release build. | ||
| // Signing with the debug keys for now, so `flutter run --release` works. | ||
| signingConfig signingConfigs.debug |
There was a problem hiding this comment.
Are the changes to this file part of the PR?
There was a problem hiding this comment.
They are intentional but was supposed to be on main branch. They revert
changes so we can keep building APK's via CI
There was a problem hiding this comment.
Reverted as there's another open PR addressing this specifically:
erdemyerebasmaz
force-pushed
the
status_text
branch
from
0d9860e
to
53a22a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents LSP cannot open channel message when account isn't connected yet(where
AccountState.connectionStatusisnullorConnectionStatus.disconnected).Changelist:
Use
AccountState.connectionStatusswitch case to displayStatusTextwidgetsAccountState&LspStatefrom parent widgetImprove readability in
ReceivableBTCBoxby usingisChannelOpeningAvailablevariableOpeningFeeParamstoFeeMessagewhen channel opening is availableMake
_loadingMessageempty string by defaultCorrect typos in
isChannelOpeningAvailiablevariableannimated_loader_dialog.dartfile nameOther changelist:
Display ReverseSwapsInProgressPage when there are "reverse swaps in progress" 18cc62e)
Beautify SwapErrorMessage 736f325
Pass ReverseSwapFeesRequest to fetchReverseSwapFees 21d9d7e
Apply breez_bridge -> breez_sdk file renaming 53a22a0