json diagnostic #1091
Merged
json diagnostic #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok300
approved these changes
Oct 7, 2024
JssDWt
force-pushed
the
jssdwt-json-diagnostic
branch
from
37eaae0
to
35b19a9
Compare
roeierez
approved these changes
Oct 8, 2024
dangeross
approved these changes
Oct 9, 2024
serde_json has no simple way to serialize specific field types as hex, until specialization is merged. This commit contains a hack to serialize all Vec<u8> fields as hex anyway. It is impossible to check the type of a generic type parameter at runtime. So all values are first serialized, then attempted to deserialize into a Vec<u8>. If that works, the found vector will be serialized as a hex string, rather than an array of numbers. This is not a performant machanism, but it gets the job done. As long as it is only used for dev commands and diagnostic data it should be fine. At least all those number arrays in the diagnostic data are now gone, without having to duplicate every struct definition just for serialization. Note that the 'Value' serialization is a copy of the real one.
JssDWt
force-pushed
the
jssdwt-json-diagnostic
branch
from
35b19a9
to
ce23e32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialize the diagnostic data into a single json document.
In this PR also an attempt to serialize
Vec<u8>as hex. It works, but became a bit of a giant cumbersome project. See the commit message for more information.