Diagnostic data: include SDK version and git hash #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JssDWt good idea. I'll wait until you merge the JSON hex PR, then I'll rebase this one. |
I'm off until Friday, maybe you can include that commit in this PR for now. Just the commit that creates the json document, not the hex serializer. |
ok300
force-pushed
the
ok300-diagnostic-incl-sdk-version
branch
from
3b29c9f
to
c5a1ebf
Compare
|
I rebased on #1091 . |
dangeross
approved these changes
Oct 9, 2024
JssDWt
force-pushed
the
jssdwt-json-diagnostic
branch
from
35b19a9
to
ce23e32
Compare
ok300
force-pushed
the
ok300-diagnostic-incl-sdk-version
branch
from
c5a1ebf
to
d8b1400
Compare
JssDWt
pushed a commit
that referenced
this pull request
Oct 14, 2024
JssDWt
pushed a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the SDK version in the diagnostic data output: